-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Quantcast adapter for Prebid 1.0 #1753
Conversation
This reverts commit 459ca31.
modules/quantcastBidAdapter.js
Outdated
method: 'POST', | ||
url, | ||
withCredentials: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to pass withCredentials:true
. Its already set in bidderFactory https://github.com/prebid/Prebid.js/blob/master/src/adapters/bidderFactory.js#L263
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed 1322e00
modules/quantcastBidAdapter.js
Outdated
const { ad, cpm, width, height } = bid; | ||
|
||
return { | ||
ad, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add required params. Please check http://prebid.org/dev-docs/bidder-adapter-1.html for list
Also bidderCode
was previously required param but now you can remove that as it is handled by bidderFactory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/quantcastBidAdapter.js
Outdated
|
||
adaptermanager.registerBidAdapter(new QuantcastAdapter(), 'quantcast'); | ||
getUserSyncs(syncOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this method if not needed at this moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed 1322e00
* @return {Bid[]} An array of bids which were nested inside the server. | ||
* | ||
*/ | ||
interpretResponse(serverResponse) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1742 got merged recently.
The first argument to interpretResponse now looks like this:
{
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}
You'll have to pull master and update the spec so that it looks digs into that object as well now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modules/quantcastBidAdapter.js
Outdated
export const spec = { | ||
code: BIDDER_CODE, | ||
|
||
// `BaseAdapter` model saves adapter from having to make the AJAX call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment chunk can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed 1322e00
I talked to our team and we are going add the missing required parameters later today. |
I have updated all the required changes @jaiminpanchal27 mentioned in the issue. The corresponding back-end change will deploy soon. |
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
* Add v1.0 adapter skeleton * Fix a typo in variable name declaration * Change spec dependencies * Add new describes for test * Move URL detechtion inside buildRequests method * Add necessary cases * Clean test cases * Export Quantcast adapter constants * Implemenent test cases * Fix wrong ports number * Correct test cases * Make string with single quote * Remove unused statements * Revert "Remove unused statements" This reverts commit 459ca31. * Remove unused statements * Change string to single quote * Fix sizes type * Fix the sizes propty name typo in the spec * Remove unused method, key value and comments * Update the spec * Change code using single quote * Update the first argument for interpretResponse method and its spec * Handle undefined Server Response * Add required params from the server response
* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits) Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) ...
* Add v1.0 adapter skeleton * Fix a typo in variable name declaration * Change spec dependencies * Add new describes for test * Move URL detechtion inside buildRequests method * Add necessary cases * Clean test cases * Export Quantcast adapter constants * Implemenent test cases * Fix wrong ports number * Correct test cases * Make string with single quote * Remove unused statements * Revert "Remove unused statements" This reverts commit 459ca31. * Remove unused statements * Change string to single quote * Fix sizes type * Fix the sizes propty name typo in the spec * Remove unused method, key value and comments * Update the spec * Change code using single quote * Update the first argument for interpretResponse method and its spec * Handle undefined Server Response * Add required params from the server response
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information
N/A